http://codereview.chromium.org/155109/diff/1/4 File src/arm/macro-assembler-arm.cc (right):
http://codereview.chromium.org/155109/diff/1/4#newcode299 Line 299: #elif // !defined(V8_HOST_ARCH_ARM) On 2009/07/07 08:14:16, Erik Corry wrote: > I find the comment clearer without the ! here. Done by avoiding the need for "!". http://codereview.chromium.org/155109/diff/1/4#newcode305 Line 305: #endif // !defined(V8_HOST_ARCH_ARM) On 2009/07/07 08:14:16, Erik Corry wrote: > And without the ! here. Done. http://codereview.chromium.org/155109/diff/1/2 File src/arm/simulator-arm.cc (right): http://codereview.chromium.org/155109/diff/1/2#newcode1104 Line 1104: Format(instr, "mla'cond's 'rd, 'rm, 'rs, 'rn"); On 2009/07/07 08:14:16, Erik Corry wrote: > Should be 'rn 'rm 'rs 'rd for similar reasons to the above. Fixed by copying the whole block out of the disassembler (including the updated comment.) http://codereview.chromium.org/155109 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
