This issue is pretty minor. It only comes up when the condition is unconditionally true.
I'm not sure how much that comes up on ARM where we don't do compile-time constant folding yet. My guess is it's only the optimization "typeof(blah) != string" where the string is not one returned by typeof. http://codereview.chromium.org/155234/diff/1/2 File src/arm/codegen-arm.cc (right): http://codereview.chromium.org/155234/diff/1/2#newcode2434 Line 2434: if (frame_ != NULL) { You only need to jump around the else part if you are going to emit it. You could write: if (else_.is_linked()) { JumpTarget exit; if (has_valid_frame()) exit.Jump(); LoadAndSpill(node->else_expression(), typeof_state()); if (exit.is_linked()) exit.Bind(); } http://codereview.chromium.org/155234 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
