http://codereview.chromium.org/155234/diff/1/2
File src/arm/codegen-arm.cc (right):

http://codereview.chromium.org/155234/diff/1/2#newcode2434
Line 2434: if (frame_ != NULL) {
On 2009/07/09 01:20:31, Kevin Millikin wrote:
> You only need to jump around the else part if you are going to emit
it.  You
> could write:

> if (else_.is_linked()) {
>    JumpTarget exit;
>    if (has_valid_frame()) exit.Jump();
>    LoadAndSpill(node->else_expression(), typeof_state());
>    if (exit.is_linked()) exit.Bind();
> }

Done.  I left the binding of the else_ JumpTarget in there though.  :-)

http://codereview.chromium.org/155234

--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to