LGTM with comments.
http://codereview.chromium.org/149326/diff/1/3 File src/debug.cc (right): http://codereview.chromium.org/149326/diff/1/3#newcode1294 Line 1294: // function apply or call was called on This comment needs updating. http://codereview.chromium.org/149326/diff/1/3#newcode1305 Line 1305: if (expressions_start + 1 >= expressions_count) { This is rather strange. Either you are sure that the condition can never be true, in which case you should remove the if. Or you think it can be true in which case you should remove the ASSERT. http://codereview.chromium.org/149326/diff/1/2 File test/mjsunit/debug-stepin-function-call.js (right): http://codereview.chromium.org/149326/diff/1/2#newcode69 Line 69: g.call(null, 3); This file seems to test only call, not apply. http://codereview.chromium.org/149326 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
