http://codereview.chromium.org/149326/diff/1/3 File src/debug.cc (right):
http://codereview.chromium.org/149326/diff/1/3#newcode1294 Line 1294: // function apply or call was called on On 2009/07/09 13:41:02, Erik Corry wrote: > This comment needs updating. Done. http://codereview.chromium.org/149326/diff/1/3#newcode1305 Line 1305: if (expressions_start + 1 >= expressions_count) { On 2009/07/09 13:41:02, Erik Corry wrote: > This is rather strange. Either you are sure that the condition can never be > true, in which case you should remove the if. Or you think it can be true in > which case you should remove the ASSERT. Done. This code is replaced completely to handle cases when the f.call is a part of a bigger expression. http://codereview.chromium.org/149326/diff/1/2 File test/mjsunit/debug-stepin-function-call.js (right): http://codereview.chromium.org/149326/diff/1/2#newcode69 Line 69: g.call(null, 3); On 2009/07/09 13:41:02, Erik Corry wrote: > This file seems to test only call, not apply. Done.Added tetsts for f.apply http://codereview.chromium.org/149326 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
