http://codereview.chromium.org/149542/diff/7/1008
File src/objects.cc (right):

http://codereview.chromium.org/149542/diff/7/1008#newcode212
Line 212: return Object::GetPropertyWithDefinedGetter(receiver,
Since the debugger can cause GCs, you have to wrap 'receiver' in a
handle as well and have a call to GetPropertyWithDefinedGetter inside
the if (using the handles).

Would it be possible to add a test that forces a GC in the HandleStepIn
code?

http://codereview.chromium.org/149542/diff/7/1008#newcode1627
Line 1627: return SetPropertyWithDefinedSetter(JSFunction::cast(setter),
value);
Same as above.  You have to wrap value in a handle as well for the
debugger case and have a call to SetPropertyWIthDefinedSetter inside of
the if (using the handles).

http://codereview.chromium.org/149542

--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to