Thanks, Ivan!
http://codereview.chromium.org/155437/diff/1/2 File src/platform-macos.cc (right): http://codereview.chromium.org/155437/diff/1/2#newcode212 Line 212: const mach_header *header = _dyld_get_image_header(i); On 2009/07/13 20:18:21, iposva wrote: > The correct style is "mach_header* header". Done. http://codereview.chromium.org/155437/diff/1/2#newcode215 Line 215: char *code_ptr; On 2009/07/13 20:18:21, iposva wrote: > The correct style is "char* code_ptr". > I also assume that you did not assign at the declaration because that would have > run over the line length? No, it's just a lack of attention. Fixed, thanks! http://codereview.chromium.org/155437/diff/1/3 File tools/mac-nm (right): http://codereview.chromium.org/155437/diff/1/3#newcode6 Line 6: nm $@ | c++filt -p -i On 2009/07/13 20:18:21, iposva wrote: > How about adding comments what the parameters to c++filt mean? And an overall > comment what this script tries to achieve? Thanks! Added comments. http://codereview.chromium.org/155437/diff/1/4 File tools/mac-tick-processor (right): http://codereview.chromium.org/155437/diff/1/4#newcode2 Line 2: On 2009/07/13 20:18:21, iposva wrote: > Maybe a small comment what this driver script tries to do? Done. http://codereview.chromium.org/155437 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
