LGTM with small comments. -Ivan
http://codereview.chromium.org/155437/diff/1/2 File src/platform-macos.cc (right): http://codereview.chromium.org/155437/diff/1/2#newcode212 Line 212: const mach_header *header = _dyld_get_image_header(i); The correct style is "mach_header* header". http://codereview.chromium.org/155437/diff/1/2#newcode215 Line 215: char *code_ptr; The correct style is "char* code_ptr". I also assume that you did not assign at the declaration because that would have run over the line length? http://codereview.chromium.org/155437/diff/1/3 File tools/mac-nm (right): http://codereview.chromium.org/155437/diff/1/3#newcode6 Line 6: nm $@ | c++filt -p -i How about adding comments what the parameters to c++filt mean? And an overall comment what this script tries to achieve? Thanks! http://codereview.chromium.org/155437/diff/1/4 File tools/mac-tick-processor (right): http://codereview.chromium.org/155437/diff/1/4#newcode2 Line 2: Maybe a small comment what this driver script tries to do? http://codereview.chromium.org/155437 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
