LGTM if you fix line 747.
http://codereview.chromium.org/149673/diff/1/3 File src/bootstrapper.cc (left): http://codereview.chromium.org/149673/diff/1/3#oldcode1137 Line 1137: I think the empty line was here for a reason. There are other statement blocks with empty lines at the bottom if they are followed by an else part in this file. I would leave it in. http://codereview.chromium.org/149673/diff/1/4 File src/ic.cc (right): http://codereview.chromium.org/149673/diff/1/4#newcode747 Line 747: if (false && FLAG_use_ic) { Please don't commit this. http://codereview.chromium.org/149673/diff/1/4#newcode989 Line 989: // TODO(X64): Enable inline cache for StoreIC. Why not wrap the entire if (FLAG_use_ic) like the other places? http://codereview.chromium.org/149673/diff/1/4#newcode989 Line 989: // TODO(X64): Enable inline cache for StoreIC. Weird indentation. http://codereview.chromium.org/149673 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
