http://codereview.chromium.org/149673/diff/1/3 File src/bootstrapper.cc (left):
http://codereview.chromium.org/149673/diff/1/3#oldcode1137 Line 1137: On 2009/07/15 11:52:15, Kasper Lund wrote: > I think the empty line was here for a reason. There are other statement blocks > with empty lines at the bottom if they are followed by an else part in this > file. I would leave it in. Done. http://codereview.chromium.org/149673/diff/1/4 File src/ic.cc (right): http://codereview.chromium.org/149673/diff/1/4#newcode747 Line 747: if (false && FLAG_use_ic) { On 2009/07/15 11:52:15, Kasper Lund wrote: > Please don't commit this. Changed to an #ifndef block. http://codereview.chromium.org/149673/diff/1/4#newcode989 Line 989: // TODO(X64): Enable inline cache for StoreIC. On 2009/07/15 11:52:15, Kasper Lund wrote: > Why not wrap the entire if (FLAG_use_ic) like the other places? We needed to use LookupForWrite. Made explicit. http://codereview.chromium.org/149673/diff/1/4#newcode989 Line 989: // TODO(X64): Enable inline cache for StoreIC. On 2009/07/15 11:52:15, Kasper Lund wrote: > Weird indentation. Done. http://codereview.chromium.org/149673 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
