LGTM
http://codereview.chromium.org/159504/diff/1/2 File src/heap.cc (right): http://codereview.chromium.org/159504/diff/1/2#newcode37 Line 37: #include "jsregexp-inl.h" // for ZoneSplayTree I think we should move ZoneSplayTree to zone.h/zone-inl.h. http://codereview.chromium.org/159504/diff/1/2#newcode3396 Line 3396: namespace { Why do you need this? http://codereview.chromium.org/159504/diff/1/2#newcode3406 Line 3406: struct TreeConfig { Maybe you should add a comment on why it is OK to use raw object pointers here and why you are just comparing pointer values. http://codereview.chromium.org/159504 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
