http://codereview.chromium.org/159504/diff/1/2 File src/heap.cc (right):
http://codereview.chromium.org/159504/diff/1/2#newcode37 Line 37: #include "jsregexp-inl.h" // for ZoneSplayTree On 2009/07/29 07:17:46, Søren Gjesse wrote: > I think we should move ZoneSplayTree to zone.h/zone-inl.h. Done. As 'jsregexp-inl.h' only contained ZoneSplayTree implementation, I've removed it. http://codereview.chromium.org/159504/diff/1/2#newcode3396 Line 3396: namespace { On 2009/07/29 07:17:46, Søren Gjesse wrote: > Why do you need this? Unnamed namespaces are allowed and even encouraged in .cc files, to avoid runtime naming conflicts. http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Namespaces#Namespaces http://codereview.chromium.org/159504/diff/1/2#newcode3406 Line 3406: struct TreeConfig { On 2009/07/29 07:17:46, Søren Gjesse wrote: > Maybe you should add a comment on why it is OK to use raw object pointers here > and why you are just comparing pointer values. Done. http://codereview.chromium.org/159504 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
