LGTM
http://codereview.chromium.org/159581/diff/1/2 File include/v8.h (right): http://codereview.chromium.org/159581/diff/1/2#newcode1976 Line 1976: PROFILER_FLAG_EMPTY = 0, EMPTY -> NONE http://codereview.chromium.org/159581/diff/1/2#newcode2144 Line 2144: static void SetProfilerFlags(int flags); How about changing this to be called StartProfiling? http://codereview.chromium.org/159581/diff/1/2#newcode2154 Line 2154: static void ClearProfilerFlags(int flags); and this to StopProfiling? http://codereview.chromium.org/159581/diff/1/2#newcode2161 Line 2161: static int GetProfilerFlags(); and GetActiveProfiling/GetCurrentProfiling? http://codereview.chromium.org/159581/diff/1/3 File src/api.cc (right): http://codereview.chromium.org/159581/diff/1/3#newcode3244 Line 3244: i::FLAG_log_gc = true; Are you planning on somehow storing the current profiling flags inside the Logger and only use FLAG_log_gc (and FLAG_prof) to initialize it, instead of having FLAG_log_gc controlling the heap profiling? http://codereview.chromium.org/159581 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
