OK, I've performed several renamings to make introduced function names more consistent with existing ones.
http://codereview.chromium.org/159581/diff/1/2 File include/v8.h (right): http://codereview.chromium.org/159581/diff/1/2#newcode1976 Line 1976: PROFILER_FLAG_EMPTY = 0, On 2009/07/29 09:30:20, Søren Gjesse wrote: > EMPTY -> NONE Done. http://codereview.chromium.org/159581/diff/1/2#newcode2144 Line 2144: static void SetProfilerFlags(int flags); On 2009/07/29 09:30:20, Søren Gjesse wrote: > How about changing this to be called StartProfiling? I think you're right in the sense that 'SetProfilerFlags' doesn't specifies that V8 will start profiling, it looks more like setting up a configuration, and thus confusing. But having two functions named similar: 'ResumeProfiling' and 'StartProfiling' is confusing too. I decided to follow Win API tradition and call it ResumeProfilerEx. http://codereview.chromium.org/159581/diff/1/2#newcode2154 Line 2154: static void ClearProfilerFlags(int flags); On 2009/07/29 09:30:20, Søren Gjesse wrote: > and this to StopProfiling? PauseProfilerEx http://codereview.chromium.org/159581/diff/1/2#newcode2161 Line 2161: static int GetProfilerFlags(); On 2009/07/29 09:30:20, Søren Gjesse wrote: > and GetActiveProfiling/GetCurrentProfiling? GetActiveProfilerModules. I also changed enum's name to ProfilerModules. http://codereview.chromium.org/159581/diff/1/3 File src/api.cc (right): http://codereview.chromium.org/159581/diff/1/3#newcode3244 Line 3244: i::FLAG_log_gc = true; On 2009/07/29 09:30:20, Søren Gjesse wrote: > Are you planning on somehow storing the current profiling flags inside the > Logger and only use FLAG_log_gc (and FLAG_prof) to initialize it, instead of > having FLAG_log_gc controlling the heap profiling? Maybe somewhere inside 'heap' module. For now I want to introduce API functions and make them work somehow, so I'm simply using the fact that currently HeapProfiler class behavior is controlled with this flag. http://codereview.chromium.org/159581 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
