You should change the none_value name. It's too generic. Other than that it still LGTM.
http://codereview.chromium.org/140069/diff/8019/8028 File src/heap.h (right): http://codereview.chromium.org/140069/diff/8019/8028#newcode113 Line 113: V(Object, none_value, NoneValue) \ I think you should call this something else. This is too generic for my liking. How about something like no_interceptor_result_sentinel? http://codereview.chromium.org/140069 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
