https://codereview.chromium.org/351853005/diff/1/src/apinatives.js
File src/apinatives.js (right):
https://codereview.chromium.org/351853005/diff/1/src/apinatives.js#newcode42
src/apinatives.js:42: result = %ToFastProperties(result);
Is this actually needed in the then case?
https://codereview.chromium.org/351853005/diff/1/src/regexp.js
File src/regexp.js (right):
https://codereview.chromium.org/351853005/diff/1/src/regexp.js#newcode409
src/regexp.js:409: %DefineOrRedefineAccessorProperty($RegExp, 'input',
RegExpGetInput,
Can't these simply be %DefineAccessorProperty now?
https://codereview.chromium.org/351853005/diff/1/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/351853005/diff/1/src/runtime.cc#newcode5359
src/runtime.cc:5359: if (key->IsName()) {
Hm, it's unfortunate that one can bypass this check by passing a
non-name that is yet to be string-converted.
I suppose it's not feasible to actually narrow this runtime function to
require a name?
https://codereview.chromium.org/351853005/diff/1/src/runtime.h
File src/runtime.h (right):
https://codereview.chromium.org/351853005/diff/1/src/runtime.h#newcode209
src/runtime.h:209: F(DefineAccessorProperty, 5, 1) \
Nit: move this down to the other Define functions
https://codereview.chromium.org/351853005/diff/1/src/runtime.h#newcode227
src/runtime.h:227: F(DefineProperty, 4, 1) \
How about naming this DefineDataProperty, for symmetry?
https://codereview.chromium.org/351853005/diff/1/src/runtime.h#newcode819
src/runtime.h:819: MUST_USE_RESULT static MaybeHandle<Object>
ForceSetObjectProperty(
It might make sense to also rename this to DefineObjectProperty.
https://codereview.chromium.org/351853005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
