Revision: 22056
Author:   [email protected]
Date:     Fri Jun 27 10:01:44 2014 UTC
Log:      Unbreak Win64 build (hopefully).

cpplint, our fragile overloading of CheckEqualsHelper and Win64 don't
really play together very well...

[email protected]

Review URL: https://codereview.chromium.org/354143003
http://code.google.com/p/v8/source/detail?r=22056

Modified:
 /branches/bleeding_edge/test/cctest/test-ostreams.cc

=======================================
--- /branches/bleeding_edge/test/cctest/test-ostreams.cc Fri Jun 27 08:42:17 2014 UTC +++ /branches/bleeding_edge/test/cctest/test-ostreams.cc Fri Jun 27 10:01:44 2014 UTC
@@ -14,7 +14,8 @@

 TEST(OStringStreamConstructor) {
   OStringStream oss;
-  CHECK_EQ(0, oss.size());
+  const size_t expected_size = 0;
+  CHECK(expected_size == oss.size());
   CHECK_GT(oss.capacity(), 0);
   CHECK_NE(NULL, oss.data());
   CHECK_EQ("", oss.c_str());
@@ -42,7 +43,7 @@
       TEST_STRING TEST_STRING TEST_STRING TEST_STRING TEST_STRING
       TEST_STRING TEST_STRING TEST_STRING TEST_STRING TEST_STRING;
   const size_t expected_len = len * repeat;
-  CHECK_EQ(static_cast<int>(expected_len), oss.size());
+  CHECK(expected_len == oss.size());
   CHECK_GT(oss.capacity(), 0);
   CHECK_EQ(0, strncmp(expected, oss.data(), expected_len));
   CHECK_EQ(expected, oss.c_str());

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to