Reviewers: marja,
Message:
Committed patchset #1 manually as r22056.
Description:
Unbreak Win64 build (hopefully).
cpplint, our fragile overloading of CheckEqualsHelper and Win64 don't
really play together very well...
[email protected]
Committed: https://code.google.com/p/v8/source/detail?r=22056
Please review this at https://codereview.chromium.org/354143003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+3, -2 lines):
M test/cctest/test-ostreams.cc
Index: test/cctest/test-ostreams.cc
diff --git a/test/cctest/test-ostreams.cc b/test/cctest/test-ostreams.cc
index
3d9e2e7f1b52e976f92ff4a499c8fc18bc05aed5..c83f96d4665eb67e1fbdc8bb9c201d3283b86ed1
100644
--- a/test/cctest/test-ostreams.cc
+++ b/test/cctest/test-ostreams.cc
@@ -14,7 +14,8 @@ using namespace v8::internal;
TEST(OStringStreamConstructor) {
OStringStream oss;
- CHECK_EQ(0, oss.size());
+ const size_t expected_size = 0;
+ CHECK(expected_size == oss.size());
CHECK_GT(oss.capacity(), 0);
CHECK_NE(NULL, oss.data());
CHECK_EQ("", oss.c_str());
@@ -42,7 +43,7 @@ TEST(OStringStreamGrow) {
TEST_STRING TEST_STRING TEST_STRING TEST_STRING TEST_STRING
TEST_STRING TEST_STRING TEST_STRING TEST_STRING TEST_STRING;
const size_t expected_len = len * repeat;
- CHECK_EQ(static_cast<int>(expected_len), oss.size());
+ CHECK(expected_len == oss.size());
CHECK_GT(oss.capacity(), 0);
CHECK_EQ(0, strncmp(expected, oss.data(), expected_len));
CHECK_EQ(expected, oss.c_str());
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
