lgtm
https://codereview.chromium.org/341123003/diff/1/src/arm64/assembler-arm64.cc
File src/arm64/assembler-arm64.cc (right):
https://codereview.chromium.org/341123003/diff/1/src/arm64/assembler-arm64.cc#newcode2565
src/arm64/assembler-arm64.cc:2565: // Avoid making the assumption that
the most-significant 32 bits are zero by
Yes, this assumption will not hold if negate = true.
https://codereview.chromium.org/341123003/diff/1/src/arm64/assembler-arm64.cc#newcode2634
src/arm64/assembler-arm64.cc:2634: }
ASSERT(d >= 2) or assert below that CountLeadingZeros(d,
kXRegSizeInBits) - 57 is a valid index in multipliers array.
https://codereview.chromium.org/341123003/diff/1/src/arm64/utils-arm64.h
File src/arm64/utils-arm64.h (right):
https://codereview.chromium.org/341123003/diff/1/src/arm64/utils-arm64.h#newcode60
src/arm64/utils-arm64.h:60: uint64_t LowestSetBit(uint64_t value);
The name suggests that the function returns a bit position instead of
2^(bit position). Could you please either add a comment or rename it to
something like LargestPowerOf2Divisor.
https://codereview.chromium.org/341123003/diff/1/test/cctest/test-assembler-arm64.cc
File test/cctest/test-assembler-arm64.cc (right):
https://codereview.chromium.org/341123003/diff/1/test/cctest/test-assembler-arm64.cc#newcode599
test/cctest/test-assembler-arm64.cc:599: __ Eor(w13, w0, kWMinInt);
Do we test whether IsImmLogical actually returns true for encodable
immediates?
https://codereview.chromium.org/341123003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
