https://codereview.chromium.org/341123003/diff/1/src/arm64/assembler-arm64.cc
File src/arm64/assembler-arm64.cc (right):
https://codereview.chromium.org/341123003/diff/1/src/arm64/assembler-arm64.cc#newcode2565
src/arm64/assembler-arm64.cc:2565: // Avoid making the assumption that
the most-significant 32 bits are zero by
Altered the comment to make this clear.
https://codereview.chromium.org/341123003/diff/1/src/arm64/assembler-arm64.cc#newcode2634
src/arm64/assembler-arm64.cc:2634: }
Asserted the index to the multipliers array, as I thought the intent was
clearer this way.
https://codereview.chromium.org/341123003/diff/1/test/cctest/test-assembler-arm64.cc
File test/cctest/test-assembler-arm64.cc (right):
https://codereview.chromium.org/341123003/diff/1/test/cctest/test-assembler-arm64.cc#newcode599
test/cctest/test-assembler-arm64.cc:599: __ Eor(w13, w0, kWMinInt);
There are a number of disassembler tests that check that a logical
operation using an immediate that can be encoded in one instruction
actually uses the expected instruction.
https://codereview.chromium.org/341123003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
