LGTM.
http://codereview.chromium.org/165056/diff/1/4 File src/cfg.cc (right): http://codereview.chromium.org/165056/diff/1/4#newcode63 Line 63: if (fun->scope()->num_stack_slots() > kPointerSize) { times kBitsPerByte. http://codereview.chromium.org/165056/diff/1/2 File src/cfg.h (right): http://codereview.chromium.org/165056/diff/1/2#newcode751 Line 751: // A StatementBuilder maintains a CFG fragment accumulator. When it visits I would call this a BlockBuilder or a StatementList builder, or a basic block builder. Unless there is a new one for each statement that is added to the CFG. http://codereview.chromium.org/165056 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
