http://codereview.chromium.org/165056/diff/1/4 File src/cfg.cc (right):
http://codereview.chromium.org/165056/diff/1/4#newcode63 Line 63: if (fun->scope()->num_stack_slots() > kPointerSize) { On 2009/08/06 15:37:44, William Hesse wrote: > times kBitsPerByte. Thanks. Turns out we have kBitsPerPointer. Who knew. http://codereview.chromium.org/165056/diff/1/2 File src/cfg.h (right): http://codereview.chromium.org/165056/diff/1/2#newcode751 Line 751: // A StatementBuilder maintains a CFG fragment accumulator. When it visits On 2009/08/06 15:37:44, William Hesse wrote: > I would call this a BlockBuilder or a StatementList builder, or a basic block > builder. Unless there is a new one for each statement that is added to the CFG. I agree the name stinks (it's not building a statement). BlockBuilder is too specific (it can build a graph that may have branches and joins, not just blocks) and too generic (the 'ExpressionBuilder' is doing the same thing, so 'BlockBuilder' doesn't differentiate). StatementListBuilder is the wrong emphasis. It is primarily applied to statements not lists of them, but it can be folded over a list of statements in an obvious way. I'm probably going to call it 'StatementCfgBuilder' and eventually give it a proper Build function. For now I'll just leave it (it's simple to change). http://codereview.chromium.org/165056 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
