LGTM assuming you fix these comments.
Thanks for working on this! It got a lot cleaner and more elegant in the
last
couple of patch sets.
https://codereview.chromium.org/160073006/diff/600001/src/preparser.h
File src/preparser.h (right):
https://codereview.chromium.org/160073006/diff/600001/src/preparser.h#newcode722
src/preparser.h:722: ? kMultiParenthesizedExpression
This is not very readable. Pls clang-format.
Afaics, it suggests:
code |= is_parenthesized() ? kMultiParenthesizedExpression
: kParenthesizedExpression;
If needed, you can add parens like this:
code |= (is_parenthesized() ? kMultiParenthesizedExpression :
kParenthesizedExpression);
https://codereview.chromium.org/160073006/diff/600001/src/preparser.h#newcode2487
src/preparser.h:2487: // The vector has the items in reverse order.
Is it necessary to have the items in reverse order? It seems you always
add the right side to the collector first, but couldn't you as easily
add the left side first?
https://codereview.chromium.org/160073006/diff/600001/src/preparser.h#newcode2506
src/preparser.h:2506: CHECK_OK);
I don't think it makes sense to put CHECK_OK inside a return statement!
(See how the macro is defined.)
You might get the right thing by just putting ok here instead of
CHECK_OK... right?
https://codereview.chromium.org/160073006/diff/600001/test/cctest/test-parsing.cc
File test/cctest/test-parsing.cc (right):
https://codereview.chromium.org/160073006/diff/600001/test/cctest/test-parsing.cc#newcode1441
test/cctest/test-parsing.cc:1441:
Hey, no adding whitespaces :)
https://codereview.chromium.org/160073006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
