LGTM, with comments.
http://codereview.chromium.org/164135/diff/1/4 File src/x64/codegen-x64.cc (right): http://codereview.chromium.org/164135/diff/1/4#newcode3492 Line 3492: Immediate(static_cast<uint32_t>(kSmiTagMask | 0x80000000U))); shouldn't this be a static cast to int32_t. I think the implicit cast from uint32_t constant to int32_t which is negative causes the warning. http://codereview.chromium.org/164135/diff/1/4#newcode3516 Line 3516: __ shrl(temp.reg()); // The shift amount in ecx is implicit operand. cl (low byte of rcx), not ecx. Is this a shr or sar? Is the high bit really 0? http://codereview.chromium.org/164135/diff/1/4#newcode3519 Line 3519: __ j(greater_equal, &slow_case); greater_equal or below_equal? Are either of these really negative? http://codereview.chromium.org/164135/diff/1/4#newcode3534 Line 3534: __ movzxwl(temp.reg(), FieldOperand(object.reg(), Add the new operations to the disassembler. http://codereview.chromium.org/164135 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
