http://codereview.chromium.org/164135/diff/1/4 File src/x64/codegen-x64.cc (right):
http://codereview.chromium.org/164135/diff/1/4#newcode3492 Line 3492: Immediate(static_cast<uint32_t>(kSmiTagMask | 0x80000000U))); Done. http://codereview.chromium.org/164135/diff/1/4#newcode3516 Line 3516: __ shrl(temp.reg()); // The shift amount in ecx is implicit operand. Not sure whether high bit can be 1 (would be waste of a bit if it can't), but if it can, this should be shr. It's a String's length, shifted left, so it should be positive. http://codereview.chromium.org/164135/diff/1/4#newcode3519 Line 3519: __ j(greater_equal, &slow_case); The string length is definitly positive, the index was tested to be non-negative above (before un-smi-tagging). I.e., it doesn't matter. I'll change it to above_equal to suggest the we are dealing with positive numbers only. http://codereview.chromium.org/164135/diff/1/4#newcode3534 Line 3534: __ movzxwl(temp.reg(), FieldOperand(object.reg(), Already there. It's just a another operand size for movzxb and movzxw. http://codereview.chromium.org/164135/diff/1/4#newcode3534 Line 3534: __ movzxwl(temp.reg(), FieldOperand(object.reg(), Already there. It's just a another operand size for movzxb and movzxw. http://codereview.chromium.org/164135 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
