LGTM.
http://codereview.chromium.org/165129/diff/1/2 File src/cfg.h (right): http://codereview.chromium.org/165129/diff/1/2#newcode422 Line 422: // Load a property from a receiver, leaving the result in a location. I like PropertyLoad better. A PropertyRef to me means the EcmaScript standard Reference internal type. http://codereview.chromium.org/165129/diff/1/5 File src/x64/cfg-x64.cc (right): http://codereview.chromium.org/165129/diff/1/5#newcode151 Line 151: __ pop(kScratchRegister); // Discard key. If you don't care what you pop to, popping to a legacy register is shorter than popping to kScratchRegister (r10), because pops are 64-bit by default, so you don't need a REX prefix except to address a new register. http://codereview.chromium.org/165129 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
