http://codereview.chromium.org/165129/diff/1/2
File src/cfg.h (right):

http://codereview.chromium.org/165129/diff/1/2#newcode422
Line 422: // Load a property from a receiver, leaving the result in a
location.
On 2009/08/07 12:50:26, William Hesse wrote:
> I like PropertyLoad better.  A PropertyRef to me means the EcmaScript
standard
> Reference internal type.


Going with PropLoad.

http://codereview.chromium.org/165129/diff/1/5
File src/x64/cfg-x64.cc (right):

http://codereview.chromium.org/165129/diff/1/5#newcode151
Line 151: __ pop(kScratchRegister);  // Discard key.
On 2009/08/07 12:50:26, William Hesse wrote:
> If you don't care what you pop to, popping to a legacy register is
shorter than
> popping to kScratchRegister (r10),
> because pops are 64-bit by default, so you don't need a REX prefix
except to
> address a new register.

Thanks for the tip, using rbx.

http://codereview.chromium.org/165129

--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to