Thanks for the patch!
Boilerplate changes look generally good, there a few nits I noticed and a
patch
to factor out. I haven't looked at the arch-specific code, but will arrange
to
have somebody look at it.
https://codereview.chromium.org/371923006/diff/10001/build/detect_v8_host_arch.py
File build/detect_v8_host_arch.py (right):
https://codereview.chromium.org/371923006/diff/10001/build/detect_v8_host_arch.py#newcode43
build/detect_v8_host_arch.py:43: host_arch = platform.machine()
nit: please add extraneously removed line back in.
https://codereview.chromium.org/371923006/diff/10001/src/base/cpu.cc
File src/base/cpu.cc (right):
https://codereview.chromium.org/371923006/diff/10001/src/base/cpu.cc#newcode458
src/base/cpu.cc:458: #elif V8_HOST_ARCH_MIPS || V8_HOST_ARCH_MIPS64
Please add the deleted line in again below.
https://codereview.chromium.org/371923006/diff/10001/src/flag-definitions.h
File src/flag-definitions.h (right):
https://codereview.chromium.org/371923006/diff/10001/src/flag-definitions.h#newcode574
src/flag-definitions.h:574: "Simulator start tracing after x number of
instructions")
Could you please factor this flag and submit is separately?
https://codereview.chromium.org/371923006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
