https://codereview.chromium.org/371923006/diff/10001/build/detect_v8_host_arch.py
File build/detect_v8_host_arch.py (right):
https://codereview.chromium.org/371923006/diff/10001/build/detect_v8_host_arch.py#newcode43
build/detect_v8_host_arch.py:43: host_arch = platform.machine()
On 2014/07/08 09:01:19, danno wrote:
nit: please add extraneously removed line back in.
Done.
https://codereview.chromium.org/371923006/diff/10001/src/base/cpu.cc
File src/base/cpu.cc (right):
https://codereview.chromium.org/371923006/diff/10001/src/base/cpu.cc#newcode458
src/base/cpu.cc:458: #elif V8_HOST_ARCH_MIPS || V8_HOST_ARCH_MIPS64
On 2014/07/08 09:01:19, danno wrote:
Please add the deleted line in again below.
Done.
https://codereview.chromium.org/371923006/diff/10001/src/flag-definitions.h
File src/flag-definitions.h (right):
https://codereview.chromium.org/371923006/diff/10001/src/flag-definitions.h#newcode574
src/flag-definitions.h:574: "Simulator start tracing after x number of
instructions")
Flag and feature removed. It was used only for Mips64 debugging.
It will eventually go in separate CL.
https://codereview.chromium.org/371923006/diff/10001/src/flag-definitions.h#newcode574
src/flag-definitions.h:574: "Simulator start tracing after x number of
instructions")
On 2014/07/08 09:01:19, danno wrote:
Could you please factor this flag and submit is separately?
Done.
https://codereview.chromium.org/371923006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
