Reviewers: Igor Sheludko, Jakob,
Message:
PTAL
Description:
Fix test driver output for passes in predictable mode.
Passes in predictable mode were wrongly reported as failures by the json
progress indicator. This moves control about what is reported completely to
execution.py.
BUG=391747
LOG=n
Please review this at https://codereview.chromium.org/382443004/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+7, -4 lines):
M tools/testrunner/local/execution.py
M tools/testrunner/local/progress.py
Index: tools/testrunner/local/execution.py
diff --git a/tools/testrunner/local/execution.py
b/tools/testrunner/local/execution.py
index
d2d086c111e3c086054d7a31f97ce97a980bdd32..a339eeb85d905402607a7e50f2795f192a91ba3f
100644
--- a/tools/testrunner/local/execution.py
+++ b/tools/testrunner/local/execution.py
@@ -138,7 +138,10 @@ class Runner(object):
else:
self.succeeded += 1
self.remaining -= 1
- self.indicator.HasRun(test, has_unexpected_output)
+ # For the indicator, everything that happens after the first run is
treated
+ # as unexpected even if it flakily passes in order to include it in the
+ # output.
+ self.indicator.HasRun(test, has_unexpected_output or test.run > 1)
if has_unexpected_output:
# Rerun test failures after the indicator has processed the results.
self._MaybeRerun(pool, test)
Index: tools/testrunner/local/progress.py
diff --git a/tools/testrunner/local/progress.py
b/tools/testrunner/local/progress.py
index
2c9f650013eb5daacb75af09985009a960545806..8caa58c44ccb4864eaccfd804151961a4aed646c
100644
--- a/tools/testrunner/local/progress.py
+++ b/tools/testrunner/local/progress.py
@@ -318,9 +318,9 @@ class JsonTestProgressIndicator(ProgressIndicator):
def HasRun(self, test, has_unexpected_output):
self.progress_indicator.HasRun(test, has_unexpected_output)
- if test.run == 1 and not has_unexpected_output:
- # Omit tests that pass on the first run, but collect output of tests
- # that pass when rerun.
+ if not has_unexpected_output:
+ # Omit tests that run as expected. Passing tests of reruns after
failures
+ # will have unexpected_output to be reported here has well.
return
self.results.append({
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
