LGTM

http://codereview.chromium.org/165230/diff/1/7
File src/arm/jump-target-arm.cc (right):

http://codereview.chromium.org/165230/diff/1/7#newcode65
Line 65: // The predicate is_linked() should now be true.  The
implementation
This comment doesn't explain itself very well.

http://codereview.chromium.org/165230/diff/1/7#newcode166
Line 166: int count = cgen()->frame()->height() - expected_height_;
Should we assert that count is positive?

http://codereview.chromium.org/165230

--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to