lgtm with comments
https://codereview.chromium.org/376223002/diff/40001/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/376223002/diff/40001/include/v8.h#newcode1095
include/v8.h:1095: * produced the the same version of V8.
Nit: the the -> by the
https://codereview.chromium.org/376223002/diff/40001/src/parser.h
File src/parser.h (right):
https://codereview.chromium.org/376223002/diff/40001/src/parser.h#newcode90
src/parser.h:90: byte* symbol_data_;
symbol_data_ and symbol_data_end_ are now unnecessary, no?
https://codereview.chromium.org/376223002/diff/40001/src/preparse-data.h
File src/preparse-data.h (right):
https://codereview.chromium.org/376223002/diff/40001/src/preparse-data.h#newcode122
src/preparse-data.h:122: // Forward declaration for
CompleteParserRecorder::GetScriptData.
Nit: This comment is unnecessary.
https://codereview.chromium.org/376223002/diff/40001/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):
https://codereview.chromium.org/376223002/diff/40001/test/cctest/test-api.cc#newcode14833
test/cctest/test-api.cc:14833:
TEST(ExpectFailPreCompileDeserializationError) {
You removed the other ExpectFail tests, this one could be removed too..
doesn't add so much value after your changes.
https://codereview.chromium.org/376223002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
