https://codereview.chromium.org/376223002/diff/40001/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/376223002/diff/40001/include/v8.h#newcode1095
include/v8.h:1095: * produced the the same version of V8.
On 2014/07/10 08:48:10, marja wrote:
Nit: the the -> by the
Done.
https://codereview.chromium.org/376223002/diff/40001/src/parser.h
File src/parser.h (right):
https://codereview.chromium.org/376223002/diff/40001/src/parser.h#newcode90
src/parser.h:90: byte* symbol_data_;
On 2014/07/10 08:48:10, marja wrote:
symbol_data_ and symbol_data_end_ are now unnecessary, no?
Done.
https://codereview.chromium.org/376223002/diff/40001/src/preparse-data.h
File src/preparse-data.h (right):
https://codereview.chromium.org/376223002/diff/40001/src/preparse-data.h#newcode122
src/preparse-data.h:122: // Forward declaration for
CompleteParserRecorder::GetScriptData.
On 2014/07/10 08:48:11, marja wrote:
Nit: This comment is unnecessary.
Done.
https://codereview.chromium.org/376223002/diff/60001/src/preparse-data.h
File src/preparse-data.h (right):
https://codereview.chromium.org/376223002/diff/60001/src/preparse-data.h#newcode122
src/preparse-data.h:122: class ScriptData;
On 2014/07/10 10:05:32, vogelheim wrote:
stlye nitpick: Forward declarations near always follow the #includes
and precede
actual class definitions. Not sure if the style guide demands it, but
it's
certainly common.
Done.
https://codereview.chromium.org/376223002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
