On 2014/07/10 16:23:06, dusmil wrote:
Right, I think it is not worth saving one instruction if we are going to
sacrifice
robustness. Current tests do not need large numbers of entries, but it
does
not
mean
some heavy benchmark will not.
This change LGTM.
I uploaded an optimized version. Also PTAL I think
const int Deoptimizer::table_entry_size_ = 7 * Assembler::kInstrSize;
was not correct as the code of an entry was 8 instructions long in worst
case.
So I left it to be 7 after dropping the
addiu(sp, sp, -1 * kPointerSize);
https://codereview.chromium.org/387473003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
