On 2014/07/10 19:00:35, kilvadyb wrote:
On 2014/07/10 16:43:37, kilvadyb wrote:
> On 2014/07/10 16:35:43, dusmil wrote:
> > Ok, in the Arm/arm64 port it is used 16-bit constants for this.
> > Do it as you planned.
>
> I missed that. So I will fix it according to the arm 16 bit constant.
Thank
you
> for the reviews.
Dusan, PTAL. I could not find 16 bit constants in arm/arm64 code for table
entries. They use int for entry size and entry number/index values. But
anyway
I
created a new version which uses Branch(label) and ASSERTs that the index
is
between the int16 boundaries.
In the Arm64 port "movz" instruction is used to load 16-bit immediate in
TableEntryGenerator::GeneratePrologue (deoptimizer-arm64.cc:352).
Also, there is an assert that maximum table entry size never exceeds int16.
Now we can reduce entry size to 2 instructions, Please update patch.
https://codereview.chromium.org/387473003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
