https://codereview.chromium.org/384403002/diff/30001/src/code-stubs.h
File src/code-stubs.h (right):
https://codereview.chromium.org/384403002/diff/30001/src/code-stubs.h#newcode274
src/code-stubs.h:274: class InterfaceDescriptor {
In general, could more stuff in this class be private?
https://codereview.chromium.org/384403002/diff/30001/src/code-stubs.h#newcode276
src/code-stubs.h:276: static const Register ContextRegister();
Can you make this a virtual register that returns either the register if
needed or no_reg. That would obviate the need for
needs_context_register().
https://codereview.chromium.org/384403002/diff/30001/src/code-stubs.h#newcode283
src/code-stubs.h:283: int environment_length() const {
Since this is not an accessor with an indentical name, this should be
GetEnvironmentLength().
https://codereview.chromium.org/384403002/diff/30001/src/code-stubs.h#newcode302
src/code-stubs.h:302: Representation* register_param_representations()
const {
Does this have to be public?
https://codereview.chromium.org/384403002/diff/30001/src/code-stubs.h#newcode306
src/code-stubs.h:306: virtual bool needs_context_register() const {
return true; }
NeedsContextRegister
https://codereview.chromium.org/384403002/diff/30001/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):
https://codereview.chromium.org/384403002/diff/30001/src/hydrogen-instructions.h#newcode2345
src/hydrogen-instructions.h:2345: return
descriptor_->needs_context_register() ? 2 : 1;
Is it possible to roll this into the descriptor, too? You might need two
calls: GetParameterRepresentation and GetOperandParameterRepresentation
that do the implicit +1 if there is a context register. But that moves
the logic out of this call class.
https://codereview.chromium.org/384403002/diff/30001/src/hydrogen-instructions.h#newcode2413
src/hydrogen-instructions.h:2413: return
descriptor->environment_length() + extra_operands;
Similar to GetParameterRepresentation, you will need two version of
GetEnvironmentLength
https://codereview.chromium.org/384403002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
