Hi Danno,
Okay, here is the "full circle" back around to specifying the context
register
for all InterfaceDescriptors.
I'm pretty happy with this, but PTAL and let me know your thoughts, thanks!
--Michael
https://codereview.chromium.org/384403002/diff/30001/src/code-stubs.h
File src/code-stubs.h (right):
https://codereview.chromium.org/384403002/diff/30001/src/code-stubs.h#newcode283
src/code-stubs.h:283: int environment_length() const {
On 2014/07/15 07:48:31, danno wrote:
Since this is not an accessor with an indentical name, this should be
GetEnvironmentLength().
Done.
https://codereview.chromium.org/384403002/diff/30001/src/code-stubs.h#newcode302
src/code-stubs.h:302: Representation* register_param_representations()
const {
On 2014/07/15 07:48:31, danno wrote:
Does this have to be public?
No, it is gone, good catch.
https://codereview.chromium.org/384403002/diff/30001/src/code-stubs.h#newcode306
src/code-stubs.h:306: virtual bool needs_context_register() const {
return true; }
On 2014/07/15 07:48:31, danno wrote:
NeedsContextRegister
Done.
https://codereview.chromium.org/384403002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
