Reviewers: jarin,
Message:
PTAL
https://codereview.chromium.org/389353003/diff/60001/tools/push-to-trunk/common_includes.py
File tools/push-to-trunk/common_includes.py (right):
https://codereview.chromium.org/389353003/diff/60001/tools/push-to-trunk/common_includes.py#newcode174
tools/push-to-trunk/common_includes.py:174: def SortingKey(version):
Refactoring: Copied from releases.py.
https://codereview.chromium.org/389353003/diff/60001/tools/push-to-trunk/common_includes.py#newcode382
tools/push-to-trunk/common_includes.py:382: if re.match(r"\*?\s*%s$" %
re.escape(name), line):
Bugfix: The output of GitBranch is stripped. The old regexp didn't
detect a branch if it was the first in the output due to the white space
requirement. It also has problems with branch names that are not
properly escaped, e.g. contain many dashes.
https://codereview.chromium.org/389353003/diff/60001/tools/push-to-trunk/common_includes.py#newcode486
tools/push-to-trunk/common_includes.py:486: def SetVersion(self,
version_file, prefix):
Refactoring: Copied from push_to_trunk.py.
Description:
Add script to bump up version on bleeding edge.
The version.cc file will from now on be controlled on
bleeding edge and on trunk. The next version to use will
always be max(bleeding_edge_version, trunk_version) + 1.
The trunk and bleeding_edge versions are not semantically
tied together. The trunk branch can be used to make
independent point releases of bleeding_edge revisions.
The version on bleeding_edge will be increased if:
- the lkgr version is smaller than the version of the latest
revision,
- the lkgr version is not a version change itself,
- the tree is not closed for maintenance.
This will allow chromium to refer directly to bleeding_edge
revisions of v8. The v8 versions will not be unique, but
they will change as often as possible, dependent on the lkgr
cycle time and the frequency this script is called.
BUG=391261
Please review this at https://codereview.chromium.org/389353003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+406, -28 lines):
A tools/push-to-trunk/bump_up_version.py
M tools/push-to-trunk/common_includes.py
M tools/push-to-trunk/git_recipes.py
M tools/push-to-trunk/push_to_trunk.py
M tools/push-to-trunk/releases.py
M tools/push-to-trunk/test_scripts.py
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
