lgtm
https://codereview.chromium.org/394793002/diff/1/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/394793002/diff/1/src/objects.h#newcode8867
src/objects.h:8867: };
design nitpick: Not sure if exposing this class is the best choice.
Given that - because of the private constructor - the only use is to
call IteratingStringHasher::Hash, maybe one could simply add the static
method to StringHasher, and then IteratingStringHasher could remain an
anonymous helper class in objects.cc.
https://codereview.chromium.org/394793002/diff/1/test/cctest/test-serialize.cc
File test/cctest/test-serialize.cc (right):
https://codereview.chromium.org/394793002/diff/1/test/cctest/test-serialize.cc#newcode711
test/cctest/test-serialize.cc:711:
Just for my understanding: Previously, this would check that the 2nd
compile would use the cache (because otherwise we'd get a different
result). This CL would prevent that from working. What this checks now
is that caching will work with a string that's physically different but
logically the same?
https://codereview.chromium.org/394793002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
