https://codereview.chromium.org/394793002/diff/1/test/cctest/test-serialize.cc
File test/cctest/test-serialize.cc (right):
https://codereview.chromium.org/394793002/diff/1/test/cctest/test-serialize.cc#newcode711
test/cctest/test-serialize.cc:711:
On 2014/07/15 13:42:31, vogelheim wrote:
Just for my understanding: Previously, this would check that the 2nd
compile
would use the cache (because otherwise we'd get a different result).
This CL
would prevent that from working. What this checks now is that caching
will work
with a string that's physically different but logically the same?
You are right. Currently, if CompileScript was to simply ignore
CONSUME_CACHED_DATA, we wouldn't notice anymore. I have no idea how we
would test that though. Unless we still use a wrong source string in
release mode, where we don't have the source string verification.
https://codereview.chromium.org/394793002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
