A simple change - needs someone to sign up as a reviewer (please!)
https://codereview.chromium.org/403003002
I'm still struggling with my environment setup a little, I can't seem to get
$ git cl presubmit
to run clean. It keeps giving me
$ git cl presubmit
Loaded authentication cookies from /home/alow/.codereview_upload_cookies
Running presubmit commit checks ...
No changes in files detected. Skipping cpplint check.
Total violating files: 0
Traceback (most recent call last):
File "/home/alow/src/depot_tools/git_cl.py", line 2659, in <module>
sys.exit(main(sys.argv[1:]))
File "/home/alow/src/depot_tools/git_cl.py", line 2645, in main
return dispatcher.execute(OptionParser(), argv)
File "/home/alow/src/depot_tools/subcommand.py", line 245, in execute
return command(parser, args[1:])
File "/home/alow/src/depot_tools/git_cl.py", line 1487, in CMDpresubmit
change=cl.GetChange(base_branch, None))
File "/home/alow/src/depot_tools/git_cl.py", line 827, in RunHook
rietveld_obj=self.RpcServer())
File "/home/alow/src/depot_tools/presubmit_support.py", line 1395, in
DoPresubmitChecks
results += executer.ExecPresubmitScript(presubmit_script, filename)
File "/home/alow/src/depot_tools/presubmit_support.py", line 1312, in
ExecPresubmitScript
result = eval(function_name + '(*__args)', context)
File "<string>", line 1, in <module>
File "<string>", line 149, in CheckChangeOnCommit
File "<string>", line 114, in _CommonChecks
File "<string>", line 67, in _CheckUnwantedDependencies
ImportError: No module named checkdeps
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups
"v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
