LGTM.
http://codereview.chromium.org/165443/diff/42/1016 File src/x64/regexp-macro-assembler-x64.cc (right): http://codereview.chromium.org/165443/diff/42/1016#newcode68 Line 68: * - stack_area_top (High end of the memory area to use as I don't like "top" here. high_end, or backtrack_stack_base, or something else is better. Top means both high and top(low). http://codereview.chromium.org/165443/diff/42/1016#newcode87 Line 87: * The first seven data must provided by the calling code, e.g., by calling the Grammar. http://codereview.chromium.org/165443/diff/42/1016#newcode95 Line 95: * Entry code will ensure that the values are stored correctly if passed in This means that calls to this from generated code (not C), will depend on the platform (Windows or Linux/MacOS). I don't like the "e.g.". http://codereview.chromium.org/165443/diff/42/1016#newcode227 Line 227: // TODO(lrn): Test multiple characters at a time by loading 4 or 8 bytes Make this an issue, with a number and an owner. http://codereview.chromium.org/165443/diff/42/1016#newcode329 Line 329: #ifdef WIN64 Should these definitions be a preprocessor macro, to be defined in assembler-x64.h? I mean the macro would expand to these definitions, not that the actual names argument1,... would be macros. http://codereview.chromium.org/165443 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
