Is the refactoring satisfactory?
http://codereview.chromium.org/165443/diff/42/1004 File src/ia32/regexp-macro-assembler-ia32.cc (right): http://codereview.chromium.org/165443/diff/42/1004#newcode1165 Line 1165: Address new_stack_top = RegExpStack::EnsureCapacity(size * 2); That would be consistent. Fixed. http://codereview.chromium.org/165443/diff/42/1006 File src/jsregexp.cc (right): http://codereview.chromium.org/165443/diff/42/1006#newcode471 Line 471: } while (res == RegExpMacroAssemblerX64::RETRY); This definitly needs refactoring. Thanks for pushing it :) I'll upload a new version when I have it prettified. http://codereview.chromium.org/165443/diff/42/1006#newcode4505 Line 4505: RegExpMacroAssemblerX64::Mode mode; Done. http://codereview.chromium.org/165443/diff/42/1013 File src/regexp-stack.h (right): http://codereview.chromium.org/165443/diff/42/1013#newcode77 Line 77: static const uint32_t kMemoryTop = 0xffffffff; Probably not. It won't get hit by the current code, since we are careful never to use a RegExpStack that hasn't been allocated. I'll change it to uintptr_t -1. http://codereview.chromium.org/165443 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
