LGTM, wowhead.com has been resurrected by this patch, I'll land it for you.
https://codereview.chromium.org/410873004/diff/1/src/preparser.h
File src/preparser.h (right):
https://codereview.chromium.org/410873004/diff/1/src/preparser.h#newcode683
src/preparser.h:683: bool IsThis() const { return (code_ &
kThisExpression) == kThisExpression; }
On 2014/07/23 12:54:55, wingo wrote:
Since the kThisExpression et al are just bitflags I would write
"return code_ &
kThisExpression" instead, without the ==. That's just me though.
Looks good to
this non-owner, please pass on to an owner.
For consistency, I would leave it as it is. All this bit-fiddling has to
be abstracted, anyway. Using one enum for different purposes without any
abstraction is not nice...
https://codereview.chromium.org/410873004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
