On 2014/07/23 13:36:50, aperez wrote:
Agreed, while making the fix I was thinking that it would be nice to use
the
BitField template from "src/utils.h"... anyway, the idea was to have this
fix
applied ASAP, so let's leave cleanups for another day.
Yes, using BitField would be much better, although I don't fully understand
why
we don't simply use C++'s enums + bit fields: Even with BitField you have to
write error-prone boilerplate code, which would be automatically and safely
be
generated by the C++ compiler instead of your brain. But that's a topic for
a
separate discussion...
https://codereview.chromium.org/410873004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
