On 2014/07/29 17:11:46, rmcilroy wrote:
https://codereview.chromium.org/422063005/diff/1/src/objects-inl.h
File src/objects-inl.h (right):
https://codereview.chromium.org/422063005/diff/1/src/objects-inl.h#newcode2605
src/objects-inl.h:2605: WRITE_UINT32_FIELD(this, kSmallLayout3Offset,
small_layout_3);
Why did you have to add another layout field? I tried really hard to
avoid
this
as it adds another word to every constant pool which ends up costing a
lot of
memory unnecessarily. If you need a larger number of entries you can use
the
EXTENDED_SECTION which provides unlimited entries in a constant pool.
Re-working this as you suggest is probably the right direction to go. It'll
add
complexity but save object size. It may take a bit to get this sorted out.
https://codereview.chromium.org/422063005/diff/1/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/422063005/diff/1/src/objects.h#newcode11195
src/objects.h:11195:
It looks like this is only here to modify VerifyMarkingVisitor - this
shouldn't
be necessary - if you are getting an error that a weak object is visited
by
the
VerifyMarkingVisitor but not marked then this is a bug in the GC system.
There
was a bug before r22445, but these should have been fixed by
https://codereview.chromium.org/385163005/, so you may not see this issue
if
for
current ToT.
I believe you are correct. We moved to using constant pools as there was a
fairly big performance win on PowerPC, but it seems we're early adopters of
this
code.
https://codereview.chromium.org/422063005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
