The architecture-indepent constant pool changes look good to me (with a
comment
on object-printer.cc), thanks!
https://codereview.chromium.org/422063005/diff/40001/src/objects-printer.cc
File src/objects-printer.cc (right):
https://codereview.chromium.org/422063005/diff/40001/src/objects-printer.cc#newcode532
src/objects-printer.cc:532: os << "\n [" << i << "]: int64: " <<
get_int64_entry(i);
I would prefer that you just print out the value as both int64 and
double for all architectures - e.g.:
os << "\n [" << i << "]: int64: " << get_int64_entry(i) << " (as
double: " << get_int64_entry_as_double(i) << ")";
https://codereview.chromium.org/422063005/diff/40001/src/objects-printer.cc#newcode552
src/objects-printer.cc:552: os << "\n [" << i << "]: int64: " <<
get_int64_entry(i);
ditto.
https://codereview.chromium.org/422063005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
