https://codereview.chromium.org/436593002/diff/1/src/compiler/arm/instruction-selector-arm.cc
File src/compiler/arm/instruction-selector-arm.cc (right):
https://codereview.chromium.org/436593002/diff/1/src/compiler/arm/instruction-selector-arm.cc#newcode251
src/compiler/arm/instruction-selector-arm.cc:251: const size_t
output_count = ARRAY_SIZE(outputs);
Why'd you move that code?
https://codereview.chromium.org/436593002/diff/1/src/compiler/machine-node-factory.h
File src/compiler/machine-node-factory.h (right):
https://codereview.chromium.org/436593002/diff/1/src/compiler/machine-node-factory.h#newcode203
src/compiler/machine-node-factory.h:203: Node*
Int32AddWithOverflow(Node* a, Node* b) {
Maybe we want to return the two projection nodes from this (i.e. accept
{Node**add} {Node** ovf})? Otherwise it's easy to screw it up and use
the add directly, which is a violation.
https://codereview.chromium.org/436593002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
