On 2014/07/31 15:18:20, Benedikt Meurer wrote:
https://codereview.chromium.org/436593002/diff/1/src/compiler/arm/instruction-selector-arm.cc
File src/compiler/arm/instruction-selector-arm.cc (right):
https://codereview.chromium.org/436593002/diff/1/src/compiler/arm/instruction-selector-arm.cc#newcode251
src/compiler/arm/instruction-selector-arm.cc:251: const size_t
output_count =
ARRAY_SIZE(outputs);
For consistency; I plan to merge the two VisitBinop functions with the
next
refactoring.
https://codereview.chromium.org/436593002/diff/1/src/compiler/machine-node-factory.h
File src/compiler/machine-node-factory.h (right):
https://codereview.chromium.org/436593002/diff/1/src/compiler/machine-node-factory.h#newcode203
src/compiler/machine-node-factory.h:203: Node* Int32AddWithOverflow(Node*
a,
Node* b) {
I'd leave it this way for consistency with calls.
It's a misleading API, since one should never ever directly use this node.
https://codereview.chromium.org/436593002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
