https://codereview.chromium.org/411263004/diff/20001/src/math.js
File src/math.js (right):
https://codereview.chromium.org/411263004/diff/20001/src/math.js#newcode231
src/math.js:231: if (ix - (%_DoubleHi(y0) & 0x7ff00000) > 0x1000000) {
On 2014/08/01 07:29:55, Yang wrote:
On 2014/07/30 19:55:04, Raymond Toy wrote:
> It would certainly be good to document what this is doing. I know
the original
> didn't, but that doesn't mean we shouldn't. I can help with this.
I don't think we should be spending time documenting third_party code,
let alone
one with one-letter variable names.
I would agree if this were in fact the original code, but it's now a
translation of the C code to Javascript.
Feel free to contribute, but I'd like to not to have this CL blocked
by this.
Fair enough.
FWIW, I think the %_DoubleHi & 0x7ff00000 is extracting the (biased)
exponent from the y0, and subtracting that from ix gives a rough idea of
how close ix is to a multiple of pi. But I'm not sure.
https://codereview.chromium.org/411263004/diff/100001/test/mjsunit/sin-cos.js
File test/mjsunit/sin-cos.js (right):
https://codereview.chromium.org/411263004/diff/100001/test/mjsunit/sin-cos.js#newcode223
test/mjsunit/sin-cos.js:223: // Test KERNELTAN for |x| > 0.67434.
Comment on line 223 should probably be moved to before line 227.
https://codereview.chromium.org/411263004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
